Run SPM-generated shell scripts under bash, not /bin/sh - #58362
Open
lazerg wants to merge 2 commits into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
cipolleschi
approved these changes
Sep 8, 2026
cipolleschi
left a comment
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
Code looks good to me. I'll ask another person for an extra pair of eyes here.
chrfalch
requested changes
Sep 8, 2026
chrfalch
left a comment
chrfalch
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for fixing this! I added a request for some changes, can you take a look?
chrfalch
self-requested a review
September 8, 2026 10:58
chrfalch
approved these changes
Sep 8, 2026
chrfalch
left a comment
chrfalch
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for fixing this so quickly! We should wait for the CI to go green as well, but it is now approved.
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D119328611. |
cortinico
approved these changes
Sep 10, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
SPM setup scripts start with
set -euo pipefail, but every one of them runs under/bin/sh. On a machine where/bin/shisn't bash (e.g. dash), that fails immediately withset: Illegal option -o pipefail, so no SwiftPM build gets past the first build phase.Two spots in
generate-spm-xcodeproj.js:shellScriptPhasehardcodesshellPath: '/bin/sh'for everyPBXShellScriptBuildPhaseit builds (Sync SPM Autolinking, Embed React Native Flavored Frameworks, plugin-contributed phases), while their bodies are bash-only. Now setsshellPath: '/bin/bash', and refreshes it on an already-injected project too.shellPathentirely — Xcode reads the shell from theActionContent's ownshellToInvokeattribute instead (default/bin/sh). Now setsshellToInvoke = "/bin/bash"on both scheme creation and when adding/refreshing the pre-action on an existing scheme.Fixes #58359
Changelog:
[IOS] [FIXED] - SwiftPM: run generated build scripts under bash instead of /bin/sh, so they don't break on a host where /bin/sh isn't bash
Test Plan:
yarn test packages/react-native/scripts/spm— 838 passed, including new cases for the refreshedshellPath/shellToInvokeon a project injected before this fix, and a scheme injected before the attribute existed.